Fix incorrect behaviour on early termination - #576
Draft
WilliamRoebuck wants to merge 6 commits into
Draft
Conversation
WilliamRoebuck
requested review from
FScholPer,
MaciejKaszynski,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
September 1, 2026 09:41
WilliamRoebuck
requested a deployment
to
workflow-approval
September 1, 2026 09:41 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
September 1, 2026 09:41 — with
GitHub Actions
Waiting
WilliamRoebuck
force-pushed
the
fix/issue-553
branch
from
September 1, 2026 09:42
47ffd6c to
4594829
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
September 1, 2026 09:42 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
September 1, 2026 09:42 — with
GitHub Actions
Waiting
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
WilliamRoebuck
force-pushed
the
fix/issue-553
branch
from
September 1, 2026 09:49
4594829 to
20e63c3
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
September 1, 2026 09:49 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
September 1, 2026 09:49 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
September 1, 2026 11:38 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
September 1, 2026 11:38 — with
GitHub Actions
Waiting
WilliamRoebuck
marked this pull request as draft
September 1, 2026 15:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UnexpectedTerminationevent instead of assumingkErrorAfterReadyMight also \fix\ #567 & #503, but I have not been able to reproduce those failures.