Fix: Resolve log bridge FFI stable compiler compatibility - #275
Fix: Resolve log bridge FFI stable compiler compatibility#275ShoroukRamzy wants to merge 2 commits into
Conversation
Signed-off-by: sramzy1 <shorouk.ramzy@valeo.com>
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
Hi @masc2023 and @OliverHeilwagen, this PR to remove the current logging patch in eclipse-score/inc_security_crypto#49. |
|
The created documentation from the pull request is available at: docu-html |
|
Hi @pawelrutkaq, Can you please review and merge this if possible? This is needed to unblock this issue eclipse-score/inc_security_crypto#173 Thanks! |
pawelrutkaq
left a comment
There was a problem hiding this comment.
Hoever I wonder how it can block anyone since we MUST use feroceen compiler which has frozen version. I suspect crypt uses wrong compilr setup ?
|
|
||
| // Copy data into array. | ||
| let mut data = [0; _]; | ||
| let mut data = [0; 4]; |
There was a problem hiding this comment.
repeated 4 from Context , we shall use comon const for it at least
| /// Create storage for `SlotHandle`. | ||
| fn default() -> Self { | ||
| Self { _private: [0; _] } | ||
| Self { _private: [0; 24] } |
Next time use slack please, chances i get notification are low ;/ |
Hi @pawelrutkaq , Yes we are using Ferrocene but rustc is used during the bazel loading phase and that's why parsing failed before Ferrorcene to execute in the execution phase of bazel |
Unblock eclipse-score/inc_security_crypto#173
Solves eclipse-score/inc_security_crypto#185 and eclipse-score/inc_security_crypto#49
This PR resolves compiler compatibility crashes in ffi.rs when building @score_logging against modern stable Rust toolchains: