Skip to content

Fix: Resolve log bridge FFI stable compiler compatibility - #275

Open
ShoroukRamzy wants to merge 2 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:fix/log-bridge-compiler-compatibility
Open

Fix: Resolve log bridge FFI stable compiler compatibility#275
ShoroukRamzy wants to merge 2 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:fix/log-bridge-compiler-compatibility

Conversation

@ShoroukRamzy

@ShoroukRamzy ShoroukRamzy commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Unblock eclipse-score/inc_security_crypto#173
Solves eclipse-score/inc_security_crypto#185 and eclipse-score/inc_security_crypto#49

This PR resolves compiler compatibility crashes in ffi.rs when building @score_logging against modern stable Rust toolchains:

  • Explicit Array Sizes: Replaces deprecated placeholder underscores ([0; _]) with explicit numeric sizes (4 and 24) matching the declared struct layouts.
  • Explicit Namespace: Prefixes the from_utf8_unchecked call with the core:: namespace to resolve undeclared module errors.

Signed-off-by: sramzy1 <shorouk.ramzy@valeo.com>
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 3a55e4ad-c547-415f-a868-031f76661ad3
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_crates', the root module requires module version score_crates@0.0.10, but got score_crates@0.0.11 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 13.593s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@ShoroukRamzy

Copy link
Copy Markdown
Contributor Author

Hi @masc2023 and @OliverHeilwagen, this PR to remove the current logging patch in eclipse-score/inc_security_crypto#49.

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@ShoroukRamzy

Copy link
Copy Markdown
Contributor Author

Hi @pawelrutkaq, Can you please review and merge this if possible? This is needed to unblock this issue eclipse-score/inc_security_crypto#173 Thanks!

@pawelrutkaq pawelrutkaq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoever I wonder how it can block anyone since we MUST use feroceen compiler which has frozen version. I suspect crypt uses wrong compilr setup ?


// Copy data into array.
let mut data = [0; _];
let mut data = [0; 4];

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repeated 4 from Context , we shall use comon const for it at least

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

/// Create storage for `SlotHandle`.
fn default() -> Self {
Self { _private: [0; _] }
Self { _private: [0; 24] }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sam here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@pawelrutkaq

Copy link
Copy Markdown
Contributor

Hi @pawelrutkaq, Can you please review and merge this if possible? This is needed to unblock this issue eclipse-score/inc_security_crypto#173 Thanks!

Next time use slack please, chances i get notification are low ;/

@ShoroukRamzy

Copy link
Copy Markdown
Contributor Author

Hoever I wonder how it can block anyone since we MUST use feroceen compiler which has frozen version. I suspect crypt uses wrong compilr setup ?

Hi @pawelrutkaq , Yes we are using Ferrocene but rustc is used during the bazel loading phase and that's why parsing failed before Ferrorcene to execute in the execution phase of bazel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

2 participants