[2470] Add selection dialog in New ItemDefinition as Payload tool - #2491
Open
jerome-obeo wants to merge 1 commit into
Open
Conversation
jerome-obeo
force-pushed
the
jgo/enh/add_item_selection_in_new_item_as_payload_tool
branch
2 times, most recently
from
August 28, 2026 15:37
590a317 to
8e549f8
Compare
Member
|
When user selects "Select existing ItemDefinition" in the selection dialog, selects an existing See: Enregistrement.de.l.ecran.2026-08-31.a.16.51.22.mov |
AxelRICHARD
reviewed
Aug 31, 2026
|
|
||
| ** Improve the edge tool creating a `FlowUsage`, by creating a `ReferenceUsage` used for the redefinition of the `FlowEnd` only when it is needed. | ||
| ** Fix the edge tool creating a `ConnectionUsage` between an `ActionUsage` graphical node and the _done_ `ActionUsage` graphical node. | ||
| ** Add the capability of selecting an existing element in `New ItemDefinition as Payload` and `New PartDefinition as Payload` tools on `AcceptAction` graphical node. The creation a new element remains available. |
Member
There was a problem hiding this comment.
The creation a new element remains available. => The creation of a new element remains available.
Each new sentence should be on a new line in our adoc files, please keep that in mind.
| @@ -1,5 +1,5 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 2024 Obeo. | |||
| * Copyright (c) 2026 Obeo. | |||
Member
There was a problem hiding this comment.
2026 => 2024, 2026
Please take the time to do your auto-review
| return self; | ||
| } | ||
|
|
||
| private Type createNewAcceptActionPayload(String payloadEClassName, AcceptActionUsage acceptActionName) { |
Member
There was a problem hiding this comment.
Please add meaningful javadoc
13 tasks
Add the selection of an existing element in `New ItemDefinition as Payload` and `New PartDefinition as Payload` tools on `AcceptAction` graphical node. Bug: eclipse-syson#2470 Signed-off-by: Jerome Gout <jerome.gout@obeosoft.com>
jerome-obeo
force-pushed
the
jgo/enh/add_item_selection_in_new_item_as_payload_tool
branch
from
August 31, 2026 15:27
8e549f8 to
3e88595
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the selection of an existing element in
New ItemDefinition as PayloadandNew PartDefinition as Payloadtools onAcceptActiongraphical node.Bug: #2470
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests