Fix fatal error when configuring a PHP-CS-Fixer fixer

[TomasVotruba]

Fixes #44.

Cause

ECS replaces symfony/console, so Symfony\Component\Console\Application is never installed.

Configuring a php-cs-fixer fixer with a deprecated option runs ConfigurableFixerTrait::configure(), which calls PhpCsFixer\Console\Application::getMajorVersion(). That class extends the missing Symfony Application, so PHP fatals resolving the parent:

PHP Fatal error: Uncaught Error: Class "Symfony\Component\Console\Application" not found

Fix

Ship a declaration-only stub in /stubs, autoloaded via classmap. ECS never runs the php-cs-fixer console, so only the class declaration is needed. php-scoper prefixes the stub with everything else, so the release build gets the prefixed name php-cs-fixer's Application extends there. stubs is added to the downgrade and scoping build steps.

CI

New Configured Fixer workflow runs bin/ecs check with a configured fixer and asserts output instead of a fatal.

before:

PHP Fatal error: Uncaught Error: Class "Symfony\Component\Console\Application" not found

after:

1) build/nested/some_file.php
@@ -1 +1,3 @@
-<?php  $x=1;
+<?php
+
+$x = 1;

[elementaire]

I have exactly the same issue with the same file NullableTypeDeclarationForDefaultNullValueFixer. I'll wait until the fix is merged and stay on 13.1.*

[TomasVotruba]

Just released https://github.com/ecsphp/ecs/releases/tag/13.2.19

Can you verify this works for you?

[elementaire]

Yes, it works for me, thanks!

[TomasVotruba]

Awesome :) great to hear that