Build of Free LAStools RPM from RapidLasso GmBH #9
Conversation
lastools-el7/Dockerfile
Outdated
| @@ -0,0 +1,27 @@ | |||
| FROM centos:7 | |||
|
|
|||
| ENV version 170414 | |||
There was a problem hiding this comment.
This variable isn't used in the file.
lastools-el7/fpm.sh
Outdated
| @@ -0,0 +1,16 @@ | |||
| #!/bin/bash | |||
|
|
|||
| version=170414 | |||
There was a problem hiding this comment.
Could you use 2017 rather than the shorthand of 17 please.
There was a problem hiding this comment.
Updated code as requested.
Note: 170414 used by rpm installed on dm-data,
lastools-170414-1.el7.x86_64.rpm.
Also if you run version for installed tools you get the following for all of then:
bin ⮀ laszip -version
LAStools (by martin@rapidlasso.com) version 170414
bin ⮀ las2txt -version
LAStools (by martin@rapidlasso.com) version 170414
There was a problem hiding this comment.
I don't think changing the version is a good idea, the version currently used, is what you get when you run add the --version option to any of the commands. Changing it is a bad idea, who cares if it represents a year or not, more important, to me at least, is that the versions match, changing it, even on the file name is not a good idea.
There was a problem hiding this comment.
Oh I didn't realise thats the version that the binary returned. In which case I agree. I thought it was just chosen by John as the date of the last changes in the CHANGES file.
There was a problem hiding this comment.
At the moment getting the version is a manual step. In a year's time is anyone going to remember how we got this version number (minus any comments of course). Better would be to, in the docker script or wherever unzips the binaries:
- unzip the binary
- Run
laszip --version(capturing the version number)
This has the benefit of being self-documenting, we know where the version comes from and keeps it in sync
There was a problem hiding this comment.
Sounds fine if that will work. Otherwise a comment is probably sufficient.
…0414. Remove unused version variable in Dockerfile.
|
Updated code to capture version in fpm.sh by running "laszip -version". |
we now capture the version by running "laszip -version".
johnpinto1
force-pushed
the
build-lastools-rpm
branch
from
eb036d3
to
26378c6
Compare
https://rapidlasso.com/lastools/