Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ambush board game #275

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Added Ambush board game #275

merged 2 commits into from
Oct 10, 2023

Conversation

SusheelThapa
Copy link
Contributor

Submitting this PR means you have:

  • searched the readme file and searched the open pull requests (no duplicates please)
  • and will follow the desired format
  • used image links that resolve correctly, are appropriately sized, and are served over HTTPS

Once your PR is created, it will trigger a build a GitHub Action (Awesome-Lint). This includes a format linting process, so if there are any issues with the build, please address them.

Do you have further questions? Check the contribution guidelines or open an issue.

When you're ready, check off the above acknowledgements and continue with your Pull Request... and thanks!

@SusheelThapa
Copy link
Contributor Author

@edm00se Can you please describe the error in merging?

@edm00se
Copy link
Owner

edm00se commented Oct 10, 2023

It looks like the awesome-lint is citing the trailing ! as failing a requirement of no trailing punctuation (it's ultimately a markdown / html header in the end). I believe we can get around this with a comment to flag the rule off for that line, as the game is titled as such. I'll have another look in a bit when I have a few minutes.

readme.md Show resolved Hide resolved
Copy link
Owner

@edm00se edm00se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

I've applied a fix for the linter and will look at the other PRs tonight.

refs: #269

@edm00se edm00se merged commit 1ae347a into edm00se:main Oct 10, 2023
3 checks passed
@edm00se edm00se added the hacktoberfest-accepted thanks for participating! label Oct 10, 2023
@SusheelThapa SusheelThapa deleted the ambush branch October 13, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted thanks for participating!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants