Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Mahjong Solitaire Game #450

Closed
wants to merge 2 commits into from

Conversation

Abhishekgupta204
Copy link

@Abhishekgupta204 Abhishekgupta204 commented Oct 26, 2023

Submitting this PR means you have:

Once your PR is created, it will trigger a build a couple of automated checks, including a GitHub Action (Awesome-Lint). This includes a format linting process, so if there are any issues with the build, please address them. The others include a check on the submission limit and also a preview of the site with your changes; please check them out, they are tools tonhelp us both.

Do you have further questions? Check the contribution guidelines or open an issue.

When you're ready, check off the above acknowledgements and continue with your Pull Request... and thanks!

Copy link
Owner

@edm00se edm00se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple things to update, primarily in formatting the description block and updating the image; the latter involves removing the two that were added directly in the repo.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file. It is extremely rare, if ever, that adding an image to this repo is needed, nor do we add it to the root of the project directory.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this as well.

@@ -351,6 +351,18 @@
| ------: | -------: | -----: |
| 2 - 4 | 8 | 30-60m |

### [Mahjong Solitaire](https://boardgamegeek.com/boardgame/67948/mahjong-solitaire)

>Mahjong Solitaire is a popular single-player tile-matching game, distinct from traditional Mahjong. The objective is to clear the board by matching identical, "open" tiles. Tiles must have no obstructions on their sides or on top. Special tiles, like flowers or seasons, can boost your score. Some versions have a timer, challenging you to clear the board before it runs out. Strategy and planning are crucial for success. It's a relaxing and mentally stimulating game enjoyed by millions.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter action is failing due to the issue on this line. After the > it needs to have a space to be properly formatted.


>Mahjong Solitaire is a popular single-player tile-matching game, distinct from traditional Mahjong. The objective is to clear the board by matching identical, "open" tiles. Tiles must have no obstructions on their sides or on top. Special tiles, like flowers or seasons, can boost your score. Some versions have a timer, challenging you to clear the board before it runs out. Strategy and planning are crucial for success. It's a relaxing and mentally stimulating game enjoyed by millions.

![Mahjong Solitaire Image](image-1.png)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image will need to be changed to something publicly available. The "adding a game" section of the formatting guide talks about how and where to find such an image.


| Players | Min. Age | Time |
| ------: | -------: | -----: |
| 1 | 3 | 20m |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you went with the community recommended minimum age as there's no "official" one. 👍

@edm00se edm00se added needs work required updates before a merge can be considered pending pending response from the submitter of a PR labels Oct 26, 2023
@edm00se
Copy link
Owner

edm00se commented Nov 1, 2023

Closing due to lack of response or update.

@edm00se edm00se closed this Nov 1, 2023
@edm00se edm00se added the invalid label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid needs work required updates before a merge can be considered pending pending response from the submitter of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants