Added Hadrian's Wall Game #463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I have added this new game "Hadrian's Wall". Please see if you merge this contribution against Hacktoberfest. As just 1 more PR need to be completed for completing 4 contributions in Hacktoberfest event, please see if you can merge it fast. Thank you so much for considering. It would be a great help.
|
@edm00se Sorry to bother you at a short notice. But please see if you can approve this PR under Hacktoberfest. Thanks a lot. |
edm00se
requested changes
Oct 31, 2023
There was a problem hiding this comment.
The addition looks fine but this Pull Request will not be accepted as is since your current changes are replacing another entry. Also please re-read the last checkbox provided by the PR template for the description; you checked it, but still @ mentioned me. I will review this PR again later on after you've made your updates to fix the removal of the other game.
|
|
||
| ### [Twilight Inscription](https://boardgamegeek.com/boardgame/361545/twilight-inscription) |
There was a problem hiding this comment.
Sorry for this. Will take proper care in future.
|
Closing this one as it's now a duplicate. |
edm00se
added
invalid
and removed
needs work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have added this new game "Hadrian's Wall". Please see if you merge this contribution against Hacktoberfest. As just 1 more PR need to be completed for completing 4 contributions in Hacktoberfest event, please see if you can merge it fast. Thank you so much for considering. It would be a great help.
Submitting this PR means you have:
@me asking for review (I will see the notifications already, no need to add noise)Once your PR is created, it will trigger a build a couple of automated checks, including a GitHub Action (Awesome-Lint). This includes a format linting process, so if there are any issues with the build, please address them. The others include a check on the submission limit and also a preview of the site with your changes; please check them out, they are tools tonhelp us both.
Do you have further questions? Check the contribution guidelines or open an issue.
When you're ready, check off the above acknowledgements and continue with your Pull Request... and thanks!