code review 1 changes

edoardottt · Sep 8, 2024 · 2bd3ae4 · 2bd3ae4
1 parent 3ad8778
commit 2bd3ae4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/internal/file/file.go b/internal/file/file.go
@@ -84,7 +84,7 @@ func CreateOutputFile(target string, subcommand string, format string, outputDir
 	_, err := os.Stat(filename)
 
 	if os.IsNotExist(err) {
-		if _, err := os.Stat(outputDir + "/"); os.IsNotExist(err) {
+		if _, err := os.Stat(fmt.Sprintf("%s/", outputDir)); os.IsNotExist(err) {
 			CreateOutputFolder(outputDir)
 		}
 		// If the file doesn't exist, create it.
@@ -123,7 +123,7 @@ func CreateIndexOutputFile(filename string, outputDir string) {
 	_, err := os.Stat(filename)
 
 	if os.IsNotExist(err) {
-		if _, err := os.Stat(outputDir + "/"); os.IsNotExist(err) {
+		if _, err := os.Stat(fmt.Sprintf("%s/", outputDir)); os.IsNotExist(err) {
 			CreateOutputFolder(outputDir)
 		}
 		// If the file doesn't exist, create it.

diff --git a/pkg/crawler/useragents.go b/pkg/crawler/useragents.go
@@ -35,6 +35,10 @@ import (
 	"time"
 )
 
+const (
+	maxRandomValue = 100
+)
+
 // genOsString generates a random OS string for a User Agent.
 func genOsString() string {
 	source := rand.NewSource(time.Now().UnixNano())
@@ -151,7 +155,6 @@ func GenerateRandomUserAgent() string {
 	source := rand.NewSource(time.Now().UnixNano())
 	rng := rand.New(source)
 
-	const maxRandomValue = 100
 	decision := rng.Intn(maxRandomValue)
 
 	var ua string

diff --git a/pkg/output/output.go b/pkg/output/output.go
@@ -36,7 +36,6 @@ import (
 	"github.com/edoardottt/cariddi/pkg/scanner"
 )
 
-// constant defined in file.go as well, redefining here for circular dependency.
 const (
 	CariddiOutputFolder = "output-cariddi"
 )