-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group Attributes of Class and Object elements of Google Wallet, to make it more maintainable. #6
Open
loechel
wants to merge
38
commits into
main
Choose a base branch
from
group_attributes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
5c23cd4
Group Attributes of Class and Object elements of Google Wallet, to ma…
loechel 0f80398
move attributes around
loechel 1e7671a
move attributes around
loechel 9b76185
rename file notification.py to message.py as it only contains message…
loechel f4d137b
fix mypy issues with __call_ order on multiple inheritance
loechel 246a3e4
move attributes around
loechel 89bb64c
start implementing transit tickets
loechel a8feb00
make credential_file depended on a path
loechel 7a327e5
make credential_file depended on a path
loechel 0c3e063
move attributes around
loechel ed7ac8e
more Classes and Objects, Types and Enums added and cleaned-up
loechel f18c7a0
fix spelling in tox.ini
loechel b55ee19
more Classes and Objects, Types and Enums added and cleaned-up
loechel 10f99e3
rename some classes to reflect Mixin character of those classes
loechel 8f73896
More documentation and revert change from model_dump to model_dump_js…
loechel 6802b85
cleanup models
loechel a9d3047
fix some classes
loechel 1c96007
add debug statement
loechel 63864c7
Update src/edutap/wallet_google/api.py
loechel dcaacbf
Update src/edutap/wallet_google/session.py
loechel 74d977c
add pydantic-settings and refactor session to use this.
loechel 7e6a7db
refactore settings
loechel 5e36e14
extend Settings
loechel 174135e
test fixtures
loechel 950d60b
test fixtures
loechel ec7222d
Merge branch 'main' into group_attributes
loechel 100b961
tox env handling
loechel 8b6b094
tox env handling, changed to default env vars
loechel 752dd79
fix enum equals method
loechel 773d230
env var check
loechel 665773f
try to fix tests
a2c80dc
try to fix settings for CI
loechel 1942abf
fix all tox tests
loechel 32f77dd
add kind attribute for retail classes
loechel 5bd87d3
fix classes
loechel ae617dd
switch requests param to json, as Content-Type-Header is not set
loechel c600f08
switch requests param to json, as Content-Type-Header is not set, rem…
loechel 6bf4ec9
switch requests param back to data, and explicitly set Content-Type-H…
loechel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ class GoogleWalletModel(BaseModel): | |
""" | ||
|
||
model_config = ConfigDict( | ||
# extra="forbid", | ||
extra="forbid", | ||
# extra="ignore", | ||
# use_enum_values=True, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am pretty sure we want to use_enum_values to be true on serialization |
||
) | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commented print should go before merge.