-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DefinitionProvider bugfixes #209
Conversation
Ensures that all symbol lookups have resolved before returning the list of locations.
Alter r_params regex to allow for spaces in data_type to include 'int unsigned'. Remove '?)' from regex to ensure that name is only the last word. Previously, 'bit' and 'int' have been matched as name. Also fixes issue where results were ignored due to forgetting to use the returned value of concat.
Add test for parameters, typed parameters (int unsigned and bit [31:0]), parameters in package and ports.
This is brilliant, thanks @LarsAur. I will start reviewing this now. |
I see that the tests failed while downloading vscode for windows. I also encountered this problem while testing the changes. Seems like the link used does not work any more (https://update.code.visualstudio.com/1.85.1/win32-archive/stable) In the importsimport { runTests, downloadAndUnzipVSCode } from '@vscode/test-electron'; In main() after setting
|
Yeah, I saw the problem and just fixed it. Can you please rebase/merge upstream/master? |
Tests are passing, Awesome! |
Main Changes
These changes attempt to fix some bugs related to the DefinitionProvider not being able to find some parameters and ports:
results.concat
for ports and ensure all symbol lookups resolve before returning the results.int unsigned
.See extended commit messages for more details.
Results after changes
Definition of port:
Definition of typed parameter:
Definition of parameter defined in package: