Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service environment correlation #773

Open
4 of 7 tasks
SylvainJuge opened this issue Mar 8, 2023 · 0 comments
Open
4 of 7 tasks

Service environment correlation #773

SylvainJuge opened this issue Mar 8, 2023 · 0 comments
Assignees
Milestone

Comments

@SylvainJuge
Copy link
Member

SylvainJuge commented Mar 8, 2023

Description

Agent implementation of specification change #766

Summary of the required changes:

  • updating documentation in Enhance service correlation doc observability-docs#2731 to invite users to provide values for service.version and service.environment (by using SERVICE_NAME and ENVIRONMENT configurations respectively).
  • when ecs-logging library is used:
    • agents provide fallback values if they are not set in ecs-logging configuration for: service.name, service.version and service.environment. Giving priority to existing values (if any) avoids making this a breaking change.
    • (optional but highly recommended) if values from agent configuration and ecs-logging configuration differ, issuing a warning is relevant to inform end user that traces and logs can't be properly correlated.
  • when log reformatting (and log sending) is used:
    • produced ECS logs should contain service.name, service.version and service.environment with values from agent configuration.

Agent Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant