Skip to content

Commit

Permalink
Fix golangci-lint 1.54 breaking changes (#1216)
Browse files Browse the repository at this point in the history
  • Loading branch information
orestisfl authored Aug 10, 2023
1 parent 14b4ffd commit 1ef7fa9
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 6 deletions.
2 changes: 2 additions & 0 deletions .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,7 @@ linters-settings:
exclude:
- '.*cloudbeat.*fetching.fetchers.k8s.FileCommonData'
- '.*cloudbeat.*fetching.fetchers.k8s.ProcCommonData'
- '.*cloudbeat.*fetching.fetchers.*<anonymous>'
- '.*cloudbeat.*flavors.benchmark.*<anonymous>'
tenv:
all: true
File renamed without changes.
2 changes: 1 addition & 1 deletion bin/golangci-lint
8 changes: 4 additions & 4 deletions resources/fetching/factory/k8s_factory.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ var vanillaFsPatterns = []string{
}

var vanillaRequiredProcesses = fetchers.ProcessesConfigMap{
"etcd": {},
"kube-apiserver": {},
"kube-controller": {},
"kube-scheduler": {},
"etcd": {ConfigFileArguments: nil},
"kube-apiserver": {ConfigFileArguments: nil},
"kube-controller": {ConfigFileArguments: nil},
"kube-scheduler": {ConfigFileArguments: nil},
"kubelet": {ConfigFileArguments: []string{"config"}},
}

Expand Down
8 changes: 7 additions & 1 deletion resources/fetching/fetchers/aws/rds_fetcher_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,13 @@ func (s *RdsFetcherTestSuite) TestFetcher_Fetch() {
rdsMocksReturnVals: rdsMocksReturnVals{
"DescribeDBInstances": {[]awslib.AwsResource{dbInstance1, dbInstance2}, nil},
},
expected: []fetching.ResourceInfo{{Resource: RdsResource{dbInstance: dbInstance1}}, {Resource: RdsResource{dbInstance: dbInstance2}}},
expected: []fetching.ResourceInfo{{
Resource: RdsResource{dbInstance: dbInstance1},
CycleMetadata: fetching.CycleMetadata{},
}, {
Resource: RdsResource{dbInstance: dbInstance2},
CycleMetadata: fetching.CycleMetadata{},
}},
},
}

Expand Down

0 comments on commit 1ef7fa9

Please sign in to comment.