use correct type for Azure Role Definitions

elastic · Apr 23, 2024 · f2f816f · f2f816f
1 parent d55d09f
commit f2f816f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/internal/resources/fetching/fetchers/azure/assets_fetcher.go b/internal/resources/fetching/fetchers/azure/assets_fetcher.go
@@ -201,7 +201,7 @@ func (r *AzureResource) GetElasticCommonData() (map[string]any, error) {
 			}
 			m["host.hostname"] = computerName
 		}
-	case fetching.AzureRoleDefinitionType:
+	case inventory.RoleDefinitionsType:
 		{
 			m["user.effective.id"] = r.Asset.Id
 			m["user.effective.name"] = r.Asset.Name

diff --git a/internal/resources/fetching/fetchers/azure/assets_fetcher_test.go b/internal/resources/fetching/fetchers/azure/assets_fetcher_test.go
@@ -220,9 +220,19 @@ func (s *AzureAssetsFetcherTestSuite) TestFetcher_Fetch() {
 
 			ecs, err := result.GetElasticCommonData()
 			s.Require().NoError(err)
-			if expected.Type == inventory.VirtualMachineAssetType {
-				s.Contains(ecs, "host.name")
-			} else {
+			switch expected.Type {
+			case inventory.VirtualMachineAssetType:
+				{
+					s.GreaterOrEqual(len(ecs), 1)
+					s.Contains(ecs, "host.name")
+				}
+			case inventory.RoleDefinitionsType:
+				{
+					s.Len(ecs, 2)
+					s.Contains(ecs, "user.effective.id")
+					s.Contains(ecs, "user.effective.name")
+				}
+			default:
 				s.Empty(ecs)
 			}
 		})