Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host information is incorrect #2081

Closed
5 tasks done
oren-zohar opened this issue Apr 2, 2024 · 3 comments · Fixed by #2139, #2126 or #2138
Closed
5 tasks done

Host information is incorrect #2081

oren-zohar opened this issue Apr 2, 2024 · 3 comments · Fixed by #2139, #2126 or #2138
Assignees
Labels
8.15 candidate Team:Cloud Security Cloud Security team related

Comments

@oren-zohar
Copy link
Collaborator

oren-zohar commented Apr 2, 2024

Motivation
Alerts generated from rules that were created from findings display wrong host information on the alert host flyout - the information displayed belongs to the host where the agent is running which is unrelated to the actual alert or misconfiguration (related only in KSPM). The second problem is that for alerts and misconfigurations that actually have a host or user relevant to them (which are not many) we didn't map the host or user Information to the relevant ECS fields.

Definition of done

What needs to be completed at the end of this task

  • Populate host.name and user.name with the correct values
    • AWS
    • GCP
    • Azure
  • Popoluate the relevant ECS fields

Releated

cc @JordanSh @eyalkraft

@oren-zohar oren-zohar added the Team:Cloud Security Cloud Security team related label Apr 2, 2024
@kubasobon
Copy link
Member

@kubasobon
Copy link
Member

Pushed a draft PR with changes. Tested on Azure, IT tests passing. PTAL.

@kubasobon
Copy link
Member

I have prepared separate PRs for host and user details. I have also added an integration test check to ensure I did not break CNVM, which already provides correct host section.

Please look at PR descriptions and code to find out which rules got the new Elastic Common Schema fields, since it affects only some of them.

The host section will become empty for most findings and I have confirmed with @maxcold and @Omolola-Akinleye that it should not affect our telemetry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment