Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct user info for select IAM resources #2139

Merged
merged 7 commits into from
Apr 23, 2024

Conversation

kubasobon
Copy link
Member

@kubasobon kubasobon commented Apr 16, 2024

user.* section of our findings and their ECS has been empty so far. This PR adds user details where applicable.

Summary of your changes

AWS
  • 1.4 - 1.7 - enriched; root account
  • 1.8, 1.9 - no change; Password Policy not tied to a single user
  • 1.10 - 1.15 - enriched; regular users
  • 1.16, 1.17 - Policies; enriched; making an assumption based on the spreadhsheet, changing user.effective.*
  • 1.19 - no change; AWS IAM server certificate rule
  • 1.20 - no change; AWS Access Analyzer

Azure

  • 1.23 - enriched

GCP IAM - add user data

  • 1.4, 1.7 - enriched; idendity-management
  • 1.5, 1.6, 1.8, 1.11 - no change; one finding has a full report on all users and roles (type: project-management)
  • 1.9, 1.10, 1.12, 1.14, 1.15 - no change; key-management
  • 1.17 - no change; data-processing

Related Issues

Related to #2081

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

No

@kubasobon kubasobon requested a review from a team as a code owner April 16, 2024 11:50
Copy link

mergify bot commented Apr 16, 2024

This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@kubasobon kubasobon marked this pull request as draft April 16, 2024 11:51
@kubasobon kubasobon linked an issue Apr 16, 2024 that may be closed by this pull request
5 tasks
Copy link

github-actions bot commented Apr 16, 2024

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 359
⬜ Skipped 33

@kubasobon kubasobon mentioned this pull request Apr 16, 2024
5 tasks
@kubasobon kubasobon marked this pull request as ready for review April 16, 2024 12:28
Copy link

mergify bot commented Apr 22, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b user-info upstream/user-info
git merge upstream/main
git push upstream user-info

@kubasobon kubasobon requested a review from romulets April 22, 2024 12:50
Copy link

mergify bot commented Apr 23, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b user-info upstream/user-info
git merge upstream/main
git push upstream user-info

@kubasobon kubasobon merged commit e5eb63d into elastic:main Apr 23, 2024
24 checks passed
@kubasobon kubasobon deleted the user-info branch April 23, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host information is incorrect
2 participants