gcp: NewProvider: Avoid returning nil #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orestisfl
force-pushed
the
NewProvider-not-nil
branch
from
c015031
to
5363be2
Compare
📊 Allure Report - 💚 No failures were reported.
|
As discussed in elastic#1144 (comment)
2 tasks
orestisfl
force-pushed
the
NewProvider-not-nil
branch
from
04367a1
to
c22e1e4
Compare
uri-weisman
approved these changes
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
As discussed in #1144 (comment)
This also fixes spurious error logs when running a non-GCP benchmark.
Related Issues
Checklist