Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "CloudFormation: Fix missing tags in cloud-security account" #1519

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

orestisfl
Copy link
Contributor

@orestisfl orestisfl commented Nov 2, 2023

Summary of your changes

This reverts commit d4ad5d4 before the 8.11 release.

Related Issues

Checklist

  • Make sure that 8.11 manifest is uploaded in a GH action
  • Make sure the 1.6.5 integration links to the correct file
  • Open follow up ticket for 8.12 release OR for fixing this issue in a better way

@orestisfl orestisfl requested a review from a team as a code owner November 2, 2023 15:58
@orestisfl orestisfl requested review from gurevichdmitry and removed request for a team November 2, 2023 15:58
@orestisfl orestisfl changed the title Revert "CloudFormation: Fix missing tags in cloud-security account (#… Revert "CloudFormation: Fix missing tags in cloud-security account Nov 2, 2023
@orestisfl orestisfl changed the title Revert "CloudFormation: Fix missing tags in cloud-security account Revert "CloudFormation: Fix missing tags in cloud-security account" Nov 2, 2023
Copy link
Collaborator

@oren-zohar oren-zohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the integration too?

@orestisfl
Copy link
Contributor Author

Do we need to update the integration too?

Link is hardcoded to 8.11 branch but i'll do a sanity check

@orestisfl orestisfl enabled auto-merge (squash) November 2, 2023 16:04
@orestisfl orestisfl merged commit f09efbd into elastic:8.11 Nov 2, 2023
28 of 29 checks passed
@orestisfl orestisfl deleted the 8.11-revert-tags branch November 7, 2023 12:00
orestisfl added a commit to orestisfl/cloudbeat that referenced this pull request Dec 27, 2023
…lastic#1519)

Revert "CloudFormation: Fix missing tags in cloud-security account (elastic#1415)"

This reverts commit d4ad5d4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants