Fetch AWS Management Account resources only when explicitly selected #2009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
|
kubasobon
commented
Mar 7, 2024
| @@ -67,6 +67,23 @@ Resources: | |||
| ManagedPolicyArns: | |||
| - arn:aws:iam::aws:policy/SecurityAudit | |||
|
|
|||
| # IAM Role to assume for Management Account | |||
There was a problem hiding this comment.
This role was missing. Installing to single account resulted in 0 findings.
📊 Allure Report - 💚 No failures were reported.
|
kubasobon
force-pushed
the
aws-accounts-tag
branch
from
d7457e4
to
e5f2e45
Compare
moukoublen
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
Changes introduced in this PR let user select if they want to scan the Management Account resources. Previously, the Management Account was always scanned, regardless of Accounts and/or Organizational Units selected by user. Despite making a change to Cloudbeat role assumptions, we are keeping it backward compatible.
Old role assumption logic (click to expand)
New role assumption logic (click to expand)
TODO:
Screenshot/Data
Related Issues
https://github.com/elastic/security-team/issues/8672
Checklist
I have added tests that prove my fix is effective or that my feature works