Add Lint ARM Templates step #2091
Conversation
|
This pull request does not have a backport label. Could you fix it @romulets? 🙏
|
📊 Allure Report - 💚 No failures were reported.
|
romulets
force-pushed
the
arm-ttk
branch
2 times, most recently
from
5256b45
to
ce8ecd3
Compare
romulets
force-pushed
the
arm-ttk
branch
3 times, most recently
from
afaf7b7
to
820b8e1
Compare
| { | ||
| "type": "Microsoft.Compute/virtualMachines/extensions", | ||
| "apiVersion": "2021-04-01", | ||
| "name": "cloudbeatVM/EnableMSIExtension", | ||
| "location": "[resourceGroup().location]", | ||
| "dependsOn": [ | ||
| "cloudbeatVM" | ||
| ], | ||
| "properties": { | ||
| "publisher": "Microsoft.ManagedIdentity", | ||
| "type": "ManagedIdentityExtensionForLinux", | ||
| "typeHandlerVersion": "1.0", | ||
| "autoUpgradeMinorVersion": true, | ||
| "settings": { | ||
| "port": 50342 | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Does this mean this is was not necessary before?
There was a problem hiding this comment.
It was. I discussed with @jeniawhite and it was there to grant access to the graph API.
The Microsoft.Compute/virtualMachines/extensions Microsoft.ManagedIdentity has been deprecated and should not be used. The only place I found a deprecation was on azure cli release notes. I don't know the reason nor could find a documentation for a replacement. But still, that is a rule in the linter.
Through reading around (and some assumptions), it seems that the
"identity": {
"type": "SystemAssigned"
}
Should suffice nowadays giving a managed identity to the VM.
I tested and verified everything works as expected (tests)
| "type": "string", | ||
| "defaultValue": "cloudbeat", | ||
| "metadata": { | ||
| "description": "Admin username for the OS profile (Don't change)" |
There was a problem hiding this comment.
This is in a nested deployment so I am not sure how users could potentially change that other than by editing the template.
Summary of your changes
Add ARM TTK Linter to the github workflow and fix linter errors
Test results available on #1663 (comment)
Related Issues