Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudformation access key #2123

Merged
merged 12 commits into from
Apr 16, 2024
Merged

Cloudformation access key #2123

merged 12 commits into from
Apr 16, 2024

Conversation

moukoublen
Copy link
Member

@moukoublen moukoublen commented Apr 11, 2024

Summary of your changes

Screenshot/Data

Related Issues

Fixes: #2062

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

Moved from: #2066

Copy link

mergify bot commented Apr 11, 2024

This pull request does not have a backport label. Could you fix it @moukoublen? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

Copy link

github-actions bot commented Apr 11, 2024

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 359
⬜ Skipped 33

Copy link
Collaborator

@orouz orouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

small note - i think this comment is relevant here too. to finalize this feature, we need to figure out how to enable kibana to deploy this

@moukoublen moukoublen force-pushed the cloudformation_access_key branch 5 times, most recently from b43b3fa to 89caff3 Compare April 15, 2024 07:35
@moukoublen moukoublen merged commit 72baecd into main Apr 16, 2024
24 checks passed
@moukoublen moukoublen deleted the cloudformation_access_key branch April 16, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS] Automated credentials creation flow
2 participants