Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gh artifacts upload with the latest action version #2605

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/actions/docker-images/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ inputs:
docker-images-folder:
description: 'Docker build cache folder'
required: false
default: '/tmp/.docker-images'
default: .docker-images

goos:
description: 'GOOS environment variable'
Expand Down Expand Up @@ -118,16 +118,16 @@ runs:
name: Rotate cache
shell: bash
run: |
ls -lahR /tmp/ || true
ls -lahR ${{ inputs.docker-images-folder }} || true
[[ -d ${{ inputs.docker-build-cache-folder }}-new ]] && rm -rf ${{ inputs.docker-build-cache-folder }} && mv ${{ inputs.docker-build-cache-folder }}-new ${{ inputs.docker-build-cache-folder }}

- if: ${{ inputs.build-docker-images == 'true' }}
name: Upload docker images
# Pin action version to 4.3.4 See https://github.com/actions/upload-artifact/issues/589
uses: actions/upload-artifact@v4.3.4
uses: actions/upload-artifact@v4
with:
name: docker-images
path: ${{ inputs.docker-images-folder }}
path: |
${{ inputs.docker-images-folder }}/*.tar
if-no-files-found: error
retention-days: 2
overwrite: true
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/k8s-ci/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ inputs:
docker-images-folder:
description: 'Docker build cache folder'
required: false
default: '/tmp/.docker-images'
default: .docker-images
runs:
using: composite
steps:
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ on:
# - main
# - "[0-9]+.[0-9]+"
# types: [opened, synchronize, reopened]
pull_request:
branches:
- main
- "[0-9]+.[0-9]+"
types: [opened, synchronize, reopened]
push:
branches:
- main
Expand Down Expand Up @@ -230,6 +235,7 @@ jobs:
uses: ./.github/actions/docker-images
with:
build-docker-images: 'true'
docker-images-folder: .docker-images

ci-k8s:
needs: [ init-hermit, docker-images ]
Expand Down Expand Up @@ -280,15 +286,15 @@ jobs:
uses: ./.github/actions/docker-images
with:
build-docker-images: 'false'
docker-images-folder: '/tmp/.docker-images'
docker-images-folder: .docker-images

- name: Run k8s integration tests
uses: ./.github/actions/k8s-ci
with:
kind-config: ${{ matrix.kind-config }}
test-target: ${{ matrix.test-target }}
values-file: ${{ matrix.values-file }}
docker-images-folder: '/tmp/.docker-images'
docker-images-folder: .docker-images

upload-allure-results:
needs:
Expand Down
Loading