fix(makers): config can also be a function
#180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A maker's config key can be a function but that is not well documented. This adds the necessary information to the `forge.config.js` example in the makers section.
erickzhao
changed the title
config can also be a function
erickzhao
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Thanks @instilled. I took a peek at the diff and made a few changes:
- Removed outdated comment about needing
config.forgein package.json. - Moved
forge.config.jsup in the tabs because we use that by default nowadays. - Made the example you provided into a second maker rather than a code comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A maker's config key can be a function but that is not well documented. This adds the necessary information to the
forge.config.jsexample in the makers section.