Fix shfmt

.editorconfig

@@ -7,3 +7,26 @@ charset = utf-8
 end_of_line = lf
 trim_trailing_whitespace = true
 insert_final_newline = true
+binary_next_line   = true
+switch_case_indent = true
+space_redirects    = true
+keep_padding       = false
+function_next_line = true
+never_split        = true
+
+[*.sh]
+shell_variant      = posix
+
+[*.py]
+indent_size = 4
+
+[tools/.bundle]
+ignore = true
+[tools/asdf]
+ignore = true
+[tools/bin]
+ignore = true
+[tools/node_modules]
+ignore = true
+[tools/uncrustify-*]
+ignore = true

lib/tools.bash

@@ -21,7 +21,7 @@ run_tool() {
   fi
 
   status=0
-  IFS= read -r original < <(cat "${path}")
+  original=$(cat "${path}")
   IFS= read -r stdout < <(mktemp)
   IFS= read -r stderr < <(mktemp)
 
@@ -147,7 +147,7 @@ run_tool_nimpretty() {
     if [[ "$(cat "${tmp}")" == "$(cat "${path}")" ]]; then
       printf " ↳ %s%s%s\n" "${tool}" "${DOTS:offset}" "ok"
     else
-      IFS= read -r patch < <(diff -u "${path}" "${tmp}")
+      patch=$(diff -u "${path}" "${tmp}")
       if [[ -n ${patch} ]]; then
         if [[ ${mode} == "write" ]]; then
           cat "${tmp}" >"${path}"
@@ -314,7 +314,7 @@ run_tool_shfmt() {
     return 0
   fi
   status=0
-  IFS= read -r original < <(cat "${path}")
+  original=$(cat "${path}")
   IFS= read -r stdout < <(mktemp)
   IFS= read -r stderr < <(mktemp)
 
@@ -347,6 +347,12 @@ run_tool_shfmt() {
         printf " ↳ %s%s%s\n" "${tool}" "${DOTS:offset}" "ok"
       fi
     else
+      echo ">>> $path"
+      cat "${path}"
+      echo "<<< $path"
+      echo ">>> original"
+      echo "${original}"
+      echo "<<< original"
       status=0
       printf " ↳ %s%s%s\n" "${tool}" "${DOTS:offset}" "wrote"
     fi
@@ -476,7 +482,7 @@ run_tool_uncrustify() {
   IFS= read -r stderr < <(mktemp)
   status=0
 
-  readarray -t cmd < <(interpolate \
+  cmd=$(interpolate \
     "tool" "uncrustify" \
     "lintball_dir" "${LINTBALL_DIR}" \
     "lang" "${lang}" \
@@ -490,7 +496,7 @@ run_tool_uncrustify() {
     if [[ "$(cat "${stdout}")" == "$(cat "${path}")" ]]; then
       printf " ↳ %s%s%s\n" "${tool}" "${DOTS:offset}" "ok"
     else
-      IFS= read -r patch < <(diff -u "${path}" "${stdout}")
+      patch=$(diff -u "${path}" "${stdout}")
       if [[ -n ${patch} ]]; then
         if [[ ${mode} == "write" ]]; then
           cat "${stdout}" >"${path}"

test/install-githooks.bats

@@ -38,6 +38,6 @@ teardown() {
 
 @test 'lintball install-githooks does not cause shellcheck errors' {
   run lintball install-githooks --no # 3>&-
-  run lintball check .githooks # 3>&-
+  run lintball check .githooks       # 3>&-
   assert_success
 }