Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use library(sf) in vignette #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

romainfrancois
Copy link

As part of testing reserve dependencies of the upcoming dplyr 1.0.8 (released soon), we've identified a potential issue with the vignette of this package. The tests give:

# salem

<details>

* Version: 0.2.0
* GitHub: NA
* Source code: https://github.com/cran/salem
* Date/Publication: 2020-11-05 16:40:05 UTC
* Number of recursive dependencies: 62

Run `cloud_details(, "salem")` for more info

</details>

## Newly broken

*   checking re-building of vignette outputs ... WARNING
    ```
    Error(s) in re-building vignettes:
      ...
    --- re-building ‘introduction.Rmd’ using rmarkdown
    --- finished re-building ‘introduction.Rmd’
    
    --- re-building ‘recreating_analyses.Rmd’ using rmarkdown
    Joining, by = "Month"
    Quitting from lines 348-367 (recreating_analyses.Rmd) 
    Error: processing vignette 'recreating_analyses.Rmd' failed with diagnostics:
    Can't convert NULL to a symbol.
    --- failed re-building ‘recreating_analyses.Rmd’
    
    SUMMARY: processing the following file failed:
      ‘recreating_analyses.Rmd’
    
    Error: Vignette re-building failed.
    Execution halted
    ```

Loading sf with library(sf) seems to be fixing it. I suppose this is something about method registration that is not done the same way with requireNamespace()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant