Fix duplicate ID check for many assocs/embeds
#4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-rychlewski
changed the title
many assocs/embedsmany assocs/embeds
greg-rychlewski
changed the title
many assocs/embedsmany assocs/embeds
greg-rychlewski
commented
Jul 20, 2023
josevalim
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4235
The underlying issue is that the function that extracts the pk values to check for duplicates is the same as the function that extracts the pk values to match current values to changes. The latter has to extract from
changeset.datawhile the former should check forchangeset.changesfirst and thenchangeset.data.