Add utc_datetime examples to cast/2 #4264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0idpwn
reviewed
Aug 18, 2023
Co-authored-by: felipe stival <14948182+v0idpwn@users.noreply.github.com>
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was asked by someone integrating with an Ecto based API what formats are accepted for date times and I had a hard time tracking down docs to offer. In v2 we had https://hexdocs.pm/ecto/2.0.1/Ecto.DateTime.html#cast/1
I wonder if it would be worth wrapping these implementations in their own type modules rather than inlining it? Not clear on what the implications are there exactly, but it would make for better docs I think