Include a preload joins vs. no joins discussion in the preload docs #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PragTob
commented
Oct 2, 2024
lib/ecto/query.ex
Outdated
| @@ -2667,6 +2667,34 @@ defmodule Ecto.Query do | |||
| where: l.inserted_at > c.updated_at, | |||
| preload: [:author, comments: {c, likes: l}] | |||
|
|
|||
| ## Choosing Between Preloading with Joins vs. Separate Queries | |||
There was a problem hiding this comment.
I wasn't sure whether to make it a separate section with a heading or not, but I ended up doing it because it got too big to just be part of the normal text.
I also put it "first" as it seemed most relevant to the preceeding setion flow-wise. Happy to re-evaluate and change!
I'm not sure if Ecto wants to provide this level of guidance in the docs, so I understand if this PR won't be merged. I've just seen many well-meaning people do this wrong (imo) by defaulting to joining all associations just to preload them, resulting in a lot more code and potentially worse performance. I also vaguely remember a tweet from José calling this out, but couldn't find it again. Here I tried to summarize what I think I know about the topic, hoping that it's accurate and helpful.
PragTob
force-pushed
the
preload-join-vs-no-join
branch
from
1175eac
to
a38584c
Compare
|
Updated, removed section about database load. Thanks for the feedback everyone! |
josevalim
approved these changes
Oct 7, 2024
greg-rychlewski
approved these changes
Oct 7, 2024
josevalim
reviewed
Oct 7, 2024
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if Ecto wants to provide this level of guidance in the docs, so I understand if this PR won't be merged.
I've just seen many well-meaning people do this wrong (imo) by defaulting to joining all associations just to preload them, resulting in a lot more code and potentially worse performance.
I also vaguely remember a tweet from José calling this out, but couldn't find it again.
Here I tried to summarize what I think I know about the topic, hoping that it's accurate and helpful.
As usual, thank you all very much for your work! 💚