Skip to content

add darken_colors - #100

Merged
shadowbehindthebread merged 4 commits into
mainfrom
darkcolors
Aug 1, 2026
Merged

add darken_colors#100
shadowbehindthebread merged 4 commits into
mainfrom
darkcolors

Conversation

@shadowbehindthebread

@shadowbehindthebread shadowbehindthebread commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

this epic pr (#️⃣💯🙀⁉️) goes out to all of our emo astronomers 🖤✨

  • added darken_colors, which works exactly the same as lighten_colors but mixes colors with black ([0, 0, 0,]) instead of white ([1, 1, 1]) haha
  • added ValueErrors when a value outside of [0,1] is passed to the transform strength factor

@elkogerville elkogerville left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great but its missing some things:

  • update get_complimentary_colors and get_colors, for both the function signatures and the docstrings :)

@elkogerville
elkogerville self-requested a review August 1, 2026 15:20

@elkogerville elkogerville left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Good job!

@shadowbehindthebread
shadowbehindthebread merged commit 31d29c1 into main Aug 1, 2026
15 checks passed
@shadowbehindthebread
shadowbehindthebread deleted the darkcolors branch August 1, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants