Mark the section compile optimization as not required for better compat

embeddedt · Aug 10, 2024 · 75ff154 · 75ff154
1 parent 4946445
commit 75ff154
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/...c/main/java/org/embeddedt/modernfix/common/mixin/perf/chunk_meshing/RebuildTaskMixin.java b/...c/main/java/org/embeddedt/modernfix/common/mixin/perf/chunk_meshing/RebuildTaskMixin.java
@@ -4,18 +4,20 @@
 import net.minecraft.client.renderer.chunk.RenderChunkRegion;
 import net.minecraft.core.BlockPos;
 import net.minecraft.world.level.block.state.BlockState;
+import org.embeddedt.modernfix.annotation.ClientOnlyMixin;
 import org.embeddedt.modernfix.util.blockpos.SectionBlockPosIterator;
 import org.spongepowered.asm.mixin.Mixin;
 import org.spongepowered.asm.mixin.injection.At;
 import org.spongepowered.asm.mixin.injection.Redirect;
 
 @Mixin(targets = { "net/minecraft/client/renderer/chunk/ChunkRenderDispatcher$RenderChunk$RebuildTask"}, priority = 2000)
+@ClientOnlyMixin
 public class RebuildTaskMixin {
     /**
      * @author embeddedt
      * @reason Use a much faster iterator implementation than vanilla's Guava-based one.
      */
-    @Redirect(method = "compile", at = @At(value = "INVOKE", target = "Lnet/minecraft/core/BlockPos;betweenClosed(Lnet/minecraft/core/BlockPos;Lnet/minecraft/core/BlockPos;)Ljava/lang/Iterable;"))
+    @Redirect(method = "compile", at = @At(value = "INVOKE", target = "Lnet/minecraft/core/BlockPos;betweenClosed(Lnet/minecraft/core/BlockPos;Lnet/minecraft/core/BlockPos;)Ljava/lang/Iterable;"), require = 0)
     private Iterable<BlockPos> fastBetweenClosed(BlockPos firstPos, BlockPos secondPos) {
         return () -> new SectionBlockPosIterator(firstPos);
     }
@@ -24,7 +26,7 @@ private Iterable<BlockPos> fastBetweenClosed(BlockPos firstPos, BlockPos secondP
      * @author embeddedt
      * @reason RenderChunkRegion.getBlockState is expensive, avoid calling it multiple times for the same position
      */
-    @Redirect(method = "compile", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/renderer/chunk/RenderChunkRegion;getBlockState(Lnet/minecraft/core/BlockPos;)Lnet/minecraft/world/level/block/state/BlockState;", ordinal = 1))
+    @Redirect(method = "compile", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/renderer/chunk/RenderChunkRegion;getBlockState(Lnet/minecraft/core/BlockPos;)Lnet/minecraft/world/level/block/state/BlockState;", ordinal = 1), require = 0)
     private BlockState useExistingBlockState(RenderChunkRegion instance, BlockPos pos, @Local(ordinal = 0) BlockState state) {
         return state;
     }