cadence 1.0: conform to latest capabilities apis #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dryruner is attempting to deploy a commit to the Emerald DAO Team on Vercel. A member of the Team first needs to authorize it. |
dryruner
commented
May 11, 2024
| @@ -442,7 +441,7 @@ access(all) contract FLOAT: NonFungibleToken, ViewResolver { | |||
| // A function every verifier must implement. | |||
| // Will have `assert`s in it to make sure | |||
| // the user fits some criteria. | |||
| access(account) fun verify(_ params: {String: AnyStruct}) | |||
| access(all) fun verify(_ params: {String: AnyStruct}) | |||
There was a problem hiding this comment.
@jacob-tucker is it the correct auth change here? Why was it made account-access previously?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @jacob-tucker please check here: https://forum.flow.com/t/update-on-cadence-1-0/5197, the change to make FLOAT.cdc compilable without errors.