feat: bump avsc and i18n example files #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed temporarily, re-run failed check after |
zmstone
requested changes
May 9, 2024
|
Add some get_config example. |
zmstone
reviewed
May 14, 2024
JimMoen
force-pushed
the
feat/bump-avsc-example
branch
from
bb0ca35
to
e461923
Compare
|
the default config should continue to be hocon. EMQX should type-check the config with avro schema if the schema exists. Otherwise just load it as-is |
JimMoen
force-pushed
the
feat/bump-avsc-example
branch
3 times, most recently
from
f88b569
to
9c4aae2
Compare
JimMoen
force-pushed
the
feat/bump-avsc-example
branch
3 times, most recently
from
8730696
to
ec3a307
Compare
JimMoen
force-pushed
the
feat/bump-avsc-example
branch
from
ec3a307
to
4333ab5
Compare
HJianBo
approved these changes
May 22, 2024
JimMoen
changed the title
HJianBo
approved these changes
May 22, 2024
zmstone
approved these changes
May 22, 2024
| @@ -3,20 +3,29 @@ | |||
| {description, "Another amazing EMQX plugin."}, | |||
| {version, "1.0.0", "The release version of this plugin."}, | |||
| {app_vsn, "0.1.0", "The erlang application vsn value."}, | |||
| {emqx_vsn, "v5.4.1", "EMQX version to use as a dependency."}, | |||
| {emqx_vsn, "v5.6.1", "EMQX version to use as a dependency."}, | |||
There was a problem hiding this comment.
nit:
Suggested change
| {emqx_vsn, "v5.6.1", "EMQX version to use as a dependency."}, | |
| {emqx_vsn, "v5.6.1", "EMQX version to use as a dependency for compile and test."}, |
There was a problem hiding this comment.
Will be updated when v5.7.0 released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.