fix(build): restore the import that #15 merged without - #16
Merged
Conversation
The missing import in the previous commit built fine here and failed in wfpy-ide: `npm run build` builds one workspace and esbuild strips types off the rest without checking them, while the products resolve `@dialogram/*` to these sources and compile them strictly. The platform was green and the product was red, with the error in a file the product does not own. `npm run typecheck` now covers all five packages. It found a second one already on main: a type imported from a module that re-declares rather than re-exports it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main does not compile for consumers right now. #15 was merged before its second commit was pushed, so main has the first commit only — and
sidecar-commands.tscallsrunChildProcess/describeChildFailurewithout importing them.It does not show up in this repo:
npm run buildbuilds one workspace and esbuild strips types off the rest without checking them. It shows up in wfpy-ide and streamblocks-ide, which resolve@dialogram/*to these sources and compile them strictly:This is the stranded commit, cherry-picked verbatim. It carries three things:
npm run typecheck— the gate that catches this class locally instead of in a consumer's build, where the error is in a file the consumer does not own.viewer-editors-tool.tsimportedInProcessChatToolfromchat-runtime, which re-declares rather than re-exports it. Harmless at runtime, never valid.Verified on this branch: typecheck 5/5, build, neutrality 4/4, and both shells build against it.