Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GEM_PATH to startup script #225

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

dvalfre
Copy link
Contributor

@dvalfre dvalfre commented Nov 9, 2023

Description of your patch

Add GEM_PATH to Passenger's startup script. Handles #224

Recommended Release Notes

Add GEM_PATH to Passenger's startup script.

Estimated risk

Medium - This affects the startup script of all apps running Passenger.

Components involved

Customers using Passenger as an app server.

Dependencies

N/A

Description of testing done

  • Create an app with a source code that includes gem base64 on a version different than 0.1.0.
  • Create a v7 environment
  • Select Passenger as the app server.
  • Deploy the app.
  • The app will fail to start, printing a message like You have already activated base64 0.1.0, but your Gemfile requires base64 0.1.1. This can be seen in logfile /data/<app_name>/current/log/passenger.8000.log
  • Apply this PR as an overlay on the environment.
  • Log into the instance and run su - deploy -c '/engineyard/bin/app_<app_name> restart.
  • Confirm that passenger is up & running by checking the log.

QA Instructions

  • Create an app with a source code that includes gem base64 on a version different than 0.1.0.
  • Create a v7 environment
  • Select Passenger as the app server.
  • Deploy the app.
  • The app will fail to start, printing a message like You have already activated base64 0.1.0, but your Gemfile requires base64 0.1.1. This can be seen in logfile /data/<app_name>/current/log/passenger.8000.log
  • Apply this PR as an overlay on the environment.
  • Log into the instance and run su - deploy -c '/engineyard/bin/app_<app_name> restart.
  • Confirm that passenger is up & running by checking the log.

@scottsherwood
Copy link

Patch both sandbox and production env's via cookbook overlay - Fix works perfectly and resolves the issue.

Testing completed:

  • Applied the updated cookbook to the sandbox env, shut all instances down, rebooted from a new volume, and everything worked as expcted.
  • Applied the cookbook to production, ran a few deploy's, Apply's from the interface along with manually restarting passenger in the console, and again, I can confirm that everything worked as expected.

@dvalfre dvalfre self-assigned this Dec 15, 2023
@dvalfre dvalfre requested a review from eudalov December 15, 2023 06:05
@dvalfre dvalfre merged commit f8fc2e7 into next-release Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants