Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phy/rmii: fix it for efinix #172

Merged
merged 1 commit into from
Sep 26, 2024
Merged

phy/rmii: fix it for efinix #172

merged 1 commit into from
Sep 26, 2024

Conversation

maass-hamburg
Copy link
Contributor

@enjoy-digital
On efinix platforms the clk signal of
SDROutput and SDRInput has to come
from the PLL.

@maass-hamburg
phy/rmii: fix it for efinix
3693c61 
On efinix platforms the clk signal of
`SDROutput` and `SDRInput` has to come
from the PLL.

Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com>
@trabucayre
Copy link
Collaborator

Tested for compat with nexys4ddr.
Just a small remark: clk_signal depends on refclk_cd but in both case cd_eth_rx & cd_eth_tx are connected to the corresponding reference: it's seems more easy/less noisy to use:

  • ClockSignal("eth_tx") in LiteEthRMIITX`
  • ClockSignal("eth_rx") in LiteEthRMIIRX`

@enjoy-digital enjoy-digital merged commit 7f91ebb into enjoy-digital:master Sep 26, 2024
1 check passed
@enjoy-digital
Copy link
Owner

Thanks @maass-hamburg, it's merged, I'll try to simplify is possible following your suggestions @trabucayre.

@maass-hamburg maass-hamburg deleted the phy_rmii_fix_efinix_sdr branch September 30, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maass-hamburg @trabucayre @enjoy-digital