changes

CHANGELOG.md

@@ -15,10 +15,11 @@ At the moment this project **does not** adhere to
   structure, and the `NodeInfoChanged` event were removed from the Staking Extension pallet. The
   `AttestationHandler` config type was added to the Staking Extension pallet. The `KeyProvider` and
   `AttestationQueue` config types were removed from the Attestation pallet.
-
+- In [#1134](https://github.com/entropyxyz/entropy-core/pull/1134/) the ```no-sync``` option was removed
 ### Changed
 - Use correct key rotation endpoint in OCW ([#1104](https://github.com/entropyxyz/entropy-core/pull/1104))
 - Change attestation flow to be pull based ([#1109](https://github.com/entropyxyz/entropy-core/pull/1109/))
+- Remove declare synced ([#1134](https://github.com/entropyxyz/entropy-core/pull/1134/))
 
 ## [0.3.0-rc.1](https://github.com/entropyxyz/entropy-core/compare/release/v0.2.0...release/v0.3.0-rc.1) - 2024-10-04
 

crates/threshold-signature-server/src/helpers/launch.rs

@@ -153,16 +153,6 @@ pub async fn load_kv_store(
 #[derive(Parser, Debug, Clone)]
 #[command(about, version)]
 pub struct StartupArgs {
-    /// Indicates that a Threshold server **should not** ask its peers for key-share data.
-    ///
-    /// This is useful to avoid in cases where:
-    ///
-    /// - The network is being bootstrapped and peers don't have any useful data yet.
-    ///
-    /// - There is outdated information about peers (e.g, outdated IP addresses coming from the
-    ///   on-chain registry) and we don't want to sync outdated key-shares.
-    #[arg(short = 's', long = "no-sync")]
-    pub no_sync: bool,
     /// Use the developer key Bob.
     #[arg(short = 'b', long = "bob")]
     pub bob: bool,

docker-compose.yaml

@@ -27,7 +27,6 @@ services:
       - "0.0.0.0:3001"
       - "--chain-endpoint"
       - "ws://alice-chain-node:9944"
-      - "--no-sync"
 
   # In a local devnet setup, for now, this is "Alice's chain."
   alice-chain-node:
@@ -64,7 +63,6 @@ services:
       - "0.0.0.0:3002"
       - "--chain-endpoint"
       - "ws://bob-chain-node:9944"
-      - "--no-sync"
 
   # "Bob's chain node."
   bob-chain-node:
@@ -102,7 +100,6 @@ services:
       - "0.0.0.0:3003"
       - "--chain-endpoint"
       - "ws://charlie-chain-node:9944"
-      - "--no-sync"
 
   # "Charlie's chain node."
   charlie-chain-node:
@@ -140,7 +137,6 @@ services:
       - "0.0.0.0:3004"
       - "--chain-endpoint"
       - "ws://dave-chain-node:9944"
-      - "--no-sync"
 
   # "Dave's chain node."
   dave-chain-node:

pallets/registry/src/benchmarking.rs

@@ -46,7 +46,7 @@ fn assert_last_event<T: Config>(generic_event: <T as Config>::RuntimeEvent) {
     assert_eq!(event, &system_event);
 }
 
-pub fn add_non_syncing_validators<T: Config>(
+pub fn add_validators<T: Config>(
     validator_amount: u32,
 ) -> Vec<<T as pallet_session::Config>::ValidatorId> {
     let validators = create_validators::<T>(validator_amount, SEED);
@@ -86,7 +86,7 @@ benchmarks! {
         accounts.push(account::<T::AccountId>("ts_account", i as u32, SEED));
     }
 
-    let validators = add_non_syncing_validators::<T>(MAX_SIGNERS as u32);
+    let validators = add_validators::<T>(MAX_SIGNERS as u32);
     <Validators<T>>::set(validators.clone());
 
     for i in 0..MAX_SIGNERS {
@@ -125,7 +125,7 @@ benchmarks! {
 
     // add validators
     for i in 0..MAX_SIGNERS {
-        let validators = add_non_syncing_validators::<T>(MAX_SIGNERS as u32);
+        let validators = add_validators::<T>(MAX_SIGNERS as u32);
         <Validators<T>>::set(validators.clone());
         <ThresholdToStash<T>>::insert(&threshold_account, &validators[i as usize]);
     }

pallets/staking/src/lib.rs

@@ -546,7 +546,7 @@ pub mod pallet {
             Ok(())
         }
 
-        #[pallet::call_index(7)]
+        #[pallet::call_index(6)]
         #[pallet::weight(({
             <T as Config>::WeightInfo::confirm_key_reshare_confirmed(MAX_SIGNERS as u32)
             .max(<T as Config>::WeightInfo::confirm_key_reshare_completed())