Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks to pallet propagation #1013

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

JesseAbram
Copy link
Member

Related #1009

Copy link
Contributor

@ameba23 ameba23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - so if i understand right, even though the propagation pallet has no extrinsics, we still need a weight for the on_initialize hook, as it makes writes to runtime storage.

Approving pending fixing CI - looks like a trivial fix.

@JesseAbram
Copy link
Member Author

Looks good to me - so if i understand right, even though the propagation pallet has no extrinsics, we still need a weight for the on_initialize hook, as it makes writes to runtime storage.

Approving pending fixing CI - looks like a trivial fix.

yes but not runtime storage, pretty much every operation that takes any form of time should be benchmarked (even if it doesn't require a fee) because it informs the chain how much time the operation takes up in a block, as block space is finite

@JesseAbram JesseAbram merged commit 49629ee into master Aug 19, 2024
8 checks passed
@JesseAbram JesseAbram deleted the add-benchmarks-to-pallet_propgation branch August 19, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants