Fix change_signers_info benchmark
#1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #978 a couple of extra checks were added to ensure that parameters related to signing could only change so quickly. This ended up breaking one of the benchmarks since the benchmark setup used a difference that was larger than the allowed amount. I've fixed that by reading the current values from storage (set at Genesis) and updating those by the allowed amount.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #978 a couple of extra checks were added to
ensure that parameters related to signing could only change so quickly. This ended up breaking one
of the benchmarks since the benchmark setup used a difference that was larger than the allowed
amount.
I've fixed that by reading the current values from storage (set at Genesis) and updating those by
the allowed amount.
Maybe worth revisiting #916...