Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.3.0 #1129

Merged
merged 5 commits into from
Oct 23, 2024
Merged

Release v0.3.0 #1129

merged 5 commits into from
Oct 23, 2024

Conversation

HCastano
Copy link
Collaborator

Updates versions and CHANGELOG for the full release of v0.3.0.

I made a couple small edits in order to use a released version of tdx-quote and to
address some build warnings on tests. No behaviour has changed though.

One other thing to note here is that since master has introduced some breaking changes
since the release, this PR is targeting a dedicated releases branch based off the rc.1 tag.

Follow up to #1098.

Copy link
Contributor

@ameba23 ameba23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@frankiebee
Copy link
Contributor

frankiebee commented Oct 22, 2024

Use released version of tdx-quote
ca53344

Get rid of warning when building tests
95710a1
these seem out of scope for a release pr were they meant to be here?

tdx-quote={ git="https://github.com/entropyxyz/tdx-quote", rev="cb167f2", features=[
"mock",
], optional=true }
tdx-quote={ version="0.0.1", features=["mock"], optional=true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's tdx-quote being installed from a published version

@HCastano
Copy link
Collaborator Author

@frankiebee yes these are intentional.

Use released version of tdx-quote ca53344

We already use the released version elsewhere in the codebase, so this just brings this dependency up to the same place in one crate. I wouldn't want to ship Git dependencies in case others want to publish using this crate. This is also only used for testing in that crate, so no functional changes are introduced.

Get rid of warning when building tests 95710a1

We missed an unused import warning on test builds. Again, not a functional change but something I wouldn't want to ship a full release with.

Copy link
Contributor

@mixmix mixmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all look chill.
The branch/release pattern makes it harder to review/ understand. Maybe we need to understand how core's cutting things.

I say that cos the description suggests "this is like rc1 but there were a couple changes". As JS it's unclear whether I should be testing those

@HCastano
Copy link
Collaborator Author

HCastano commented Oct 22, 2024

@mixmix the release/v0.3.0 branch was cut at the same spot where we cut the v0.3.0-rc.1 release. So the only changes between the RC and the full release will be those introduced in this PR.

If you walk through each commit individually it'll be easier to spot what was changed and how it may affect behaviour. I have not introduced any new functional changes, otherwise I would've mention that as part of the PR description.

@cooldracula
Copy link
Contributor

@vitropy is out-of-office, but I think I can speak for the team and say this looks good and DevOps approves!

@HCastano HCastano merged commit fe4c14e into release/v0.3.0 Oct 23, 2024
7 checks passed
@HCastano HCastano deleted the hc/release-v0.3.0 branch October 23, 2024 10:59
@HCastano HCastano restored the hc/release-v0.3.0 branch October 23, 2024 11:41
@HCastano HCastano deleted the hc/release-v0.3.0 branch October 23, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants