-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.3.0
#1129
Release v0.3.0
#1129
Conversation
This updates the info for the full release as well as includes a missed breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Use released version of tdx-quote Get rid of warning when building tests |
tdx-quote={ git="https://github.com/entropyxyz/tdx-quote", rev="cb167f2", features=[ | ||
"mock", | ||
], optional=true } | ||
tdx-quote={ version="0.0.1", features=["mock"], optional=true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here's tdx-quote
being installed from a published version
@frankiebee yes these are intentional. We already use the released version elsewhere in the codebase, so this just brings this dependency up to the same place in one crate. I wouldn't want to ship Git dependencies in case others want to publish using this crate. This is also only used for testing in that crate, so no functional changes are introduced. We missed an unused import warning on test builds. Again, not a functional change but something I wouldn't want to ship a full release with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes all look chill.
The branch/release pattern makes it harder to review/ understand. Maybe we need to understand how core
's cutting things.
I say that cos the description suggests "this is like rc1 but there were a couple changes". As JS it's unclear whether I should be testing those
@mixmix the If you walk through each commit individually it'll be easier to spot what was changed and how it may affect behaviour. I have not introduced any new functional changes, otherwise I would've mention that as part of the PR description. |
@vitropy is out-of-office, but I think I can speak for the team and say this looks good and DevOps approves! |
Updates versions and
CHANGELOG
for the full release ofv0.3.0
.I made a couple small edits in order to use a released version of
tdx-quote
and toaddress some build warnings on tests. No behaviour has changed though.
One other thing to note here is that since
master
has introduced some breaking changessince the release, this PR is targeting a dedicated releases branch based off the
rc.1
tag.Follow up to #1098.