Add failure_status option and spec. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @floere, thanks for the PR! I'm hoping to get a chance to check it in detail at some point this week. It'll speed things up if you can make sure that rubocop is passing on this branch, I think you might be able to |
|
Thanks for the contribution! I'll try to cut a release today. |
Merged
|
@liamdawson Thanks so much! 🙇🏻♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear Rack::ECG maintainers
First of all, thanks so much for a useful gem! 🙇🏻♂️
I wanted to return a more specific HTTP code when a check failed, in my case a 503 Service Unavailable. I added the necessary option
failure_status, code, and a spec.Please let me know if the PR needs improvements and I'll update it.