Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: x-request-id propagation not working #16

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

jonrandahl
Copy link
Contributor

@jonrandahl jonrandahl commented Oct 14, 2024

This PR resolves ticket 189

  • Fixed casing on the X-Request-Id header for SAPINT requests to match the header received from the apps using the gem.
  • Updated the previously supplied release date in the v1.5.0 entry to match the actual release date.
  • Updated the version.rb SUFFIX entry to be nil by default to ensure the gem version number is correctly formatted.

Fixed casing on the `X-Request-Id` header for SAPINT requests to match the header received from the apps using the gem.
Updated the `version.rb` `SUFFIX` entry to be `nil` by default to ensure the version number is correctly formatted.
@jonrandahl jonrandahl self-assigned this Oct 14, 2024
@jonrandahl jonrandahl marked this pull request as ready for review October 14, 2024 17:03
Copy link
Contributor

@DanielCouzens DanielCouzens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonrandahl jonrandahl merged commit e26b98b into main Oct 15, 2024
4 checks passed
@jonrandahl jonrandahl deleted the issue/189-x-request-id-propagation-not-working branch October 15, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants