Skip to content

Commit

Permalink
Merge pull request #120 from epimorphics/issue/145-missing-detailed-p…
Browse files Browse the repository at this point in the history
…pd-documentation

Handover redirections to proxy server
  • Loading branch information
jonrandahl authored Mar 13, 2024
2 parents 23f1bed + b4de49f commit c3284d4
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 17 deletions.
9 changes: 4 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,10 @@ including the SPARQL Qonsole

## 1.7.6 - 2024-03-12

- (Jon) Reconfigured the old ppd doc routes to temporarily redirect to `app/doc/ppd`
as well as set the `ppd_doc_path` variable to point to the same reconfigured
route; alongside adding tests querying the new route to ensure the route is
valid and contains the expected content as well as tests to verify the old
routes redirect with 302 temporary status
- (Jon) Reconfigured the `ppd_doc_path` variable to point to the `app/doc/ppd`
path; alongside adding tests querying the new route to ensure the route is
valid and contains the expected content. All redirections for any old routes
will now handled by the proxy server.

## 1.7.5 - 2023-11-23

Expand Down
2 changes: 0 additions & 2 deletions config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
get 'doc/hpi', to: 'doc#hpi', as: 'hpi_doc'
get 'doc/ukhpi', to: redirect('/app/ukhpi/doc', status: 302)
get 'app/doc/ppd', to: 'doc#ppd', as: 'ppd_doc'
get 'doc/ppd', to: redirect('/app/doc/ppd', status: 302)
get 'app/root/doc/ppd', to: redirect('app/doc/ppd', status: 302)
get 'doc/ukhpi-dsd', to: redirect('/app/ukhpi/doc/ukhpi-dsd', status: 302)
get 'doc/ukhpi-user-guide', to: redirect('/app/ukhpi/doc/ukhpi-user-guide', status: 302)
get 'doc/accessibility', to: 'doc#accessibility'
Expand Down
10 changes: 0 additions & 10 deletions test/integration/documentation_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,6 @@ class DocumentationTest < ActionDispatch::IntegrationTest
assert_equal(302, response.status)
end

test 'older PPD doc link redirects with permanent 302 status' do
get '/doc/ppd'
assert_equal(302, response.status)
end

test 'old PPD doc link redirects with permanent 302 status' do
get '/app/root/doc/ppd'
assert_equal(302, response.status)
end

test 'ppd_doc_path variable links correctly' do
get ppd_doc_path
assert_response :success
Expand Down

0 comments on commit c3284d4

Please sign in to comment.