Primarily Prometheus Metrics #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added additional rulesets as well as reorganised and grouped rules to allow easier reading and updating in the future
reorganised targets alphabetically as well as mirrored other improvements from the other applications in the suite
Implements improved boilerplate metrics integration
implemented the dynamic page title approach used in the other suite apps to the accessibility and privacy translation templates, as well as converted the privacy templates to match the same haml formatting language used everywhere else, alongside tweaking the application controller to improve selected language option to be applied
Now includes metrics even though the rails server is not reporting much due to content of app are static pages.
primarily comment changes
expansion of the `exp` var to `exception` in the `instrument_internal_error` metric subscriber
Now includes auth when building assets
from v.1.7.7 ~> v1.8.0
bogdanadrianmarc
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focussing primarily on ticket #148 for the addition of Prometheus metrics endpoint to the landing page, additional changes for accessibility, useability, and functionality have been interspersed.