Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates page titles #128

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Updates page titles #128

merged 3 commits into from
Aug 16, 2024

Conversation

DanielCouzens
Copy link
Contributor

Please see ticket 116

@DanielCouzens DanielCouzens self-assigned this Aug 16, 2024
@DanielCouzens DanielCouzens marked this pull request as ready for review August 16, 2024 10:28
@DanielCouzens DanielCouzens mentioned this pull request Aug 16, 2024
Closed
1 task
jonrandahl
jonrandahl requested changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@jonrandahl jonrandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small minor adjustments here, let me know if you have any questions!

app/views/download_report/bad_request.html.haml Outdated Show resolved Hide resolved
app/views/download_report/bad_request.html.haml Outdated Show resolved Hide resolved
app/views/report_design/review_report.html.haml Outdated Show resolved Hide resolved
jonrandahl
jonrandahl approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@jonrandahl jonrandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@DanielCouzens DanielCouzens merged commit 6829ce0 into dev Aug 16, 2024
2 checks passed
@DanielCouzens DanielCouzens deleted the issue/116-page-titles branch August 16, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrandahl jonrandahl Awaiting requested review from jonrandahl

Assignees

@DanielCouzens DanielCouzens

Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielCouzens @jonrandahl