Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/133 xss vulnerability hotfix #135

Merged
merged 2 commits into from
Sep 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Standard Reports UI: change log

## 1.5.3 - 2024-08
## 1.5.3 - 2024-09

- (Dan) Fixes bug XXS vulnerability [133](https://github.com/epimorphics/standard-reports-ui/issues/133)
- (Dan) Update the error messages for the postcode selectors step 3/7 so each error message is unique to the postcode selector [120](https://github.com/epimorphics/standard-reports-ui/issues/120)
- (Dan) Updates alt text for screenshots of example reports [115](https://github.com/epimorphics/standard-reports-ui/issues/115)
- (Dan) Updates report page styles so links are underlined and gives download report page a seperate page title
Expand Down
4 changes: 2 additions & 2 deletions app/models/step_select_postcode_area.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ def validate_with(workflow, value)
workflow.traverse_to(successor_step)
else
set_flash("Sorry, '#{value}' does not appear to be a valid value for a #{subtype_label}.
A #{subtype_label} is the first one or two letters of a UK postcode, for example "B"
or "TA&quot".html_safe)
A #{subtype_label} is the first one or two letters of a UK postcode, for example
'B' or 'TA'.")
end
end
end
4 changes: 2 additions & 2 deletions app/models/step_select_postcode_district.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ def validate_with(workflow, value)
workflow.traverse_to(successor_step)
else
set_flash("Sorry, '#{value}' does not appear to be a valid value for a #{subtype_label}.
A #{subtype_label} is the first part of a UK postcode, up to the space. For example
"B17" or "TA9&quot".html_safe)
A #{subtype_label} is the first part of a UK postcode, up to the space. For example
'B17' or 'TA9'.")
end
end
end
4 changes: 2 additions & 2 deletions app/models/step_select_postcode_sector.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ def validate_with(workflow, value)
workflow.traverse_to(successor_step)
else
set_flash("Sorry, '#{value}' does not appear to be a valid value for a #{subtype_label}.
A #{subtype_label} is the first part of a UK postcode, up to and including the first
digit after the space. For example "B17 0" or "TA9 3"".html_safe)
A #{subtype_label} is the first part of a UK postcode, up to and including the first
digit after the space. For example 'B17 0' or 'TA9 3'.")
end
end
end