Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Rep: updates ruby version and alpine version #144

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

DanielCouzens
Copy link
Contributor

@DanielCouzens DanielCouzens commented Oct 7, 2024

Updates Standard Reports app to 1.5.5
Updates ruby to 2.7.8
Updates alpine 3.16

@DanielCouzens DanielCouzens self-assigned this Oct 7, 2024
@DanielCouzens DanielCouzens marked this pull request as ready for review October 7, 2024 10:08
@DanielCouzens DanielCouzens changed the title updates ruby version and alpine version Standard Rep: updates ruby version and alpine version Oct 7, 2024
Copy link
Contributor

@jonrandahl jonrandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor adjustment on version cadence requested in comment, otherwise LGTM! 👍

CHANGELOG.md Outdated
@@ -1,5 +1,9 @@
# Standard Reports UI: change log

## 1.5.5 - 2024-10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change this to 1.6.0 in all required places due to the minor version update on the Ruby and Alpine versions? #my2p

Copy link
Contributor

@jonrandahl jonrandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DanielCouzens DanielCouzens merged commit ced0dff into dev Oct 7, 2024
2 checks passed
@DanielCouzens DanielCouzens deleted the issue/254-standard-rep-updates-ruby-version branch October 7, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants