fix(motion-collapsible): stop clipping once the height settles - #127
Merged
Conversation
`.motion-collapsible` carried `overflow: hidden` at all times. The clipping is only needed while the height animates, and left on it cuts anything a child draws outside its content box — focus rings most visibly, since the ring is a box-shadow set 4px out from the trigger. The result is a control inside a collapsible showing only the edges of its focus ring that happen to have padding above or beside them. In governance studio's API key dialog, the project select and the custom-expiry date picker both render a ring on the top edge alone, measured at 0px of room on the other three sides. Clip only while the animation runs. Driving this from onAnimationStart / onAnimationComplete rather than `isOpen` also covers the ResizeObserver case, where content resizes while already open and starts a fresh height animation. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.motion-collapsiblecarriedoverflow: hiddenat all times. The clipping is only needed while the height animates, and left on it cuts anything a child draws outside its content box — focus rings most visibly, since the ring is a box-shadow set 4px out from the trigger.The result is a control inside a collapsible showing only the edges of its focus ring that happen to have padding above or beside them. In governance studio's API key dialog, the project select and the custom-expiry date picker both render a ring on the top edge alone, measured at 0px of room on the other three sides.
Clip only while the animation runs. Driving this from onAnimationStart / onAnimationComplete rather than
isOpenalso covers the ResizeObserver case, where content resizes while already open and starts a fresh height animation.