Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Box.getReg #773

Merged
merged 5 commits into from
Oct 2, 2024
Merged

[6.0] Box.getReg #773

merged 5 commits into from
Oct 2, 2024

Conversation

SethDusek
Copy link
Collaborator

Closes #772

If Box.R4[Long] is called and R4 is of some type other than Long, then it should error. Previously sigma-rust would instead simply return the underlying value
…nature

Explicit type args are useful for many 6.0 methods where type can not be inferred from arguments, such as Box.getReg[T]
@coveralls
Copy link

coveralls commented Sep 30, 2024

Pull Request Test Coverage Report for Build 11100861612

Details

  • 148 of 165 (89.7%) changed or added relevant lines in 26 files are covered.
  • 9 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 79.107%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ergotree-ir/src/serialization/method_call.rs 11 13 84.62%
ergotree-ir/src/serialization/sigma_byte_reader.rs 4 6 66.67%
ergotree-interpreter/src/eval/extract_reg_as.rs 4 7 57.14%
ergotree-ir/src/mir/method_call.rs 9 12 75.0%
ergotree-interpreter/src/eval/sbox.rs 15 22 68.18%
Files with Coverage Reduction New Missed Lines %
ergotree-ir/src/ergo_tree.rs 1 85.31%
ergotree-ir/src/serialization/types.rs 4 84.67%
ergotree-ir/src/mir/expr.rs 4 81.12%
Totals Coverage Status
Change from base Build 10701623379: 0.2%
Covered Lines: 10863
Relevant Lines: 13732

💛 - Coveralls

@SethDusek SethDusek marked this pull request as ready for review October 1, 2024 01:09
@SethDusek SethDusek requested a review from kushti October 1, 2024 01:09
@SethDusek SethDusek merged commit 274287e into develop Oct 2, 2024
13 checks passed
@SethDusek SethDusek deleted the getreg6.0 branch October 7, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Box.getReg
3 participants