Use default params instead of defaultProps

ericgio · Oct 23, 2023 · 21aa439 · 21aa439
1 parent ef32d72
commit 21aa439
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/src/components/TypeaheadMenu/TypeaheadMenu.tsx b/src/components/TypeaheadMenu/TypeaheadMenu.tsx
@@ -39,7 +39,10 @@ const propTypes = {
   renderMenuItemChildren: PropTypes.func,
 };
 
-function renderMenuItemChildrenFn(option: Option, props: TypeaheadMenuProps) {
+function defaultRenderMenuItemChildren(
+  option: Option,
+  props: TypeaheadMenuProps
+) {
   return (
     <Highlighter search={props.text}>
       {getOptionLabel(option, props.labelKey)}
@@ -53,7 +56,7 @@ const TypeaheadMenu = (props: TypeaheadMenuProps) => {
     newSelectionPrefix = 'New selection: ',
     options,
     paginationText = 'Display additional results...',
-    renderMenuItemChildren = renderMenuItemChildrenFn,
+    renderMenuItemChildren = defaultRenderMenuItemChildren,
     text,
     ...menuProps
   } = props;

diff --git a/src/core/Typeahead.tsx b/src/core/Typeahead.tsx
@@ -1,7 +1,7 @@
 import PropTypes from 'prop-types';
 import React, { forwardRef } from 'react';
 
-import useTypeahead, { TypeaheadRef, defaultProps } from './useTypeahead';
+import useTypeahead, { TypeaheadRef } from './useTypeahead';
 import TypeaheadManager from './TypeaheadManager';
 
 import {
@@ -163,6 +163,5 @@ const Typeahead = forwardRef<TypeaheadRef, Props>((props, ref) => {
 
 // @ts-ignore
 Typeahead.propTypes = propTypes;
-Typeahead.defaultProps = defaultProps;
 
 export default Typeahead;
diff --git a/src/core/useTypeahead.ts b/src/core/useTypeahead.ts
@@ -47,7 +47,7 @@ import {
 
 import { DEFAULT_LABELKEY } from '../constants';
 
-export const defaultProps = {
+const defaultProps = {
   allowNew: false,
   autoFocus: false,
   caseSensitive: false,

diff --git a/src/tests/props.ts b/src/tests/props.ts