Misc git hosting fixes #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Hosting adapter causes multiple calls to be sent to 'entries' on the git_adapter(repositories_controller_path#show_with_git_instructions adds a second (non vanilla chiliproject) call. As this method is very expensive, this has a performance impact we can avoid! It might be better to provide a dedicated method to the patched git_adapter to determine whether a repository is 'empty' or not rather than having to fetch the entries, but this will work for now.
There is some logic in update_repositories to avoid 'recursion' however this does not protect against the case where an observed change leads to multiple calls to update_repositories for the same project (or projects.) An example change that could cause this is is to add a *group* with commit rights as a project's member. The update_repositories method will then get called for both the group's addition and each subsequent member of that group. This change avoids those un-neccessary secondary calls.
|
Hmm , this isn't good to pull yet,1057899 is wrong. The sentiment is right, but the approach I've taken doesn't actually work (well it works once, then never again ;) ) Not really sure how best to fix it whilst remaining 'close' to your version of the project. The primary difference in my fork was around how I managed the 'update_repositories' call, namely I did: and To wrap all requests to redmine and do the actual update_repositories call at the end of the request so we didn't repeatedly update the same project. ... I can't see a way around this if Observers are singletons (which they appear to be.) I also can't understand why I'm the only one who seems to be seeing this issue :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some, miscellaneous (hopefully un-contentious) fixes/performance improvements.